Skip to content

✨ switch to mqt-core Python package#336

Merged
burgholzer merged 25 commits intomainfrom
mqt-core-switch
Mar 5, 2025
Merged

✨ switch to mqt-core Python package#336
burgholzer merged 25 commits intomainfrom
mqt-core-switch

Conversation

@burgholzer
Copy link
Copy Markdown
Member

@burgholzer burgholzer commented Jan 27, 2024 •
edited
Loading

Description

This PR switches the project to use the newly developed mqt-core Python package.
Any Python package build will only require the mqt-core package as a build and runtime dependency and won't have to rely on fetched version of mqt-core any more.
Any regular C++ build will still use the FetchContent CMake module.

The change brings a range of advantages:

  • Uses the new load function of mqt-core that allows to load any supported circuit format as input and has better handling for Qiskit QuantumCircuit objects.
  • Simplifies the interfaces of the DDSIM Python bindings
  • Allows OpenQASM3 as an input format.

In addition, this PR updates mqt-ddsim to most of the current best practices within the MQT.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added dependencies Pull requests that update a dependency file python Pull requests that update Python code minor Part of a minor release packaging Anything related to Python packaging usability Anything related to usability labels Jan 27, 2024
@burgholzer burgholzer self-assigned this Jan 27, 2024
@burgholzer burgholzer force-pushed the mqt-core-switch branch 2 times, most recently from 7ffac4c to ee41104 Compare January 27, 2024 14:14
@burgholzer burgholzer mentioned this pull request Jan 27, 2024
Closed
4 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.15966% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.9%. Comparing base (babc960) to head (fd95157).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
include/HybridSchrodingerFeynmanSimulator.hpp 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #336     +/-   ##
=======================================
+ Coverage   92.3%   93.9%   +1.5%     
=======================================
  Files         37      37             
  Lines       2734    2648     -86     
  Branches     311     301     -10     
=======================================
- Hits        2526    2488     -38     
+ Misses       208     160     -48
Flag Coverage Δ
cpp 93.9% <98.7%> (-0.3%) ⬇️
python 94.0% <100.0%> (+6.6%) ⬆️
Files with missing lines Coverage Δ
include/PathSimulator.hpp 97.5% <100.0%> (+2.1%) ⬆️
include/ShorSimulator.hpp 100.0% <ø> (ø)
include/Simulator.hpp 92.6% <100.0%> (+1.1%) ⬆️
include/UnitarySimulator.hpp 100.0% <ø> (ø)
src/CircuitSimulator.cpp 87.7% <100.0%> (-3.5%) ⬇️
src/DeterministicNoiseSimulator.cpp 100.0% <100.0%> (ø)
src/GroverSimulator.cpp 100.0% <100.0%> (ø)
src/HybridSchrodingerFeynmanSimulator.cpp 97.7% <100.0%> (-0.1%) ⬇️
src/PathSimulator.cpp 89.9% <100.0%> (+1.0%) ⬆️
src/ShorFastSimulator.cpp 92.2% <100.0%> (-2.5%) ⬇️
... and 13 more

@burgholzer burgholzer force-pushed the mqt-core-switch branch 2 times, most recently from a2ef802 to 2d2c358 Compare February 5, 2024 22:10
@burgholzer burgholzer mentioned this pull request Feb 9, 2024
Closed
4 tasks
@burgholzer burgholzer force-pushed the mqt-core-switch branch 2 times, most recently from 61996fd to 60cd68f Compare February 14, 2024 16:18
@burgholzer burgholzer added this to the DDSIM 2.0 milestone Feb 16, 2024
@burgholzer burgholzer force-pushed the mqt-core-switch branch 2 times, most recently from 66b69b8 to bb7ffd3 Compare September 5, 2024 18:59
@burgholzer burgholzer added major Part of a major release and removed minor Part of a minor release labels Sep 6, 2024
burgholzer added a commit to munich-quantum-toolkit/core that referenced this pull request Mar 4, 2025
@burgholzer
🔧 Handle empty quantum and classical registers in qiskit to MQT trans…
c2701a0 
…lation (#849)

## Description

This pull request adds support for handling empty quantum and classical
registers during the translation process from Qiskit to MQT. This update
ensures proper translation and eliminates any potential errors caused by
empty registers.

This has come up while working on
munich-quantum-toolkit/ddsim#336

## Checklist:

- [x] The pull request only contains commits that are related to it.
- [x] I have added appropriate tests and documentation.
- [x] I have made sure that all CI jobs on GitHub pass.
- [x] The pull request introduces no new warnings and follows the
project's style guidelines.

Signed-off-by: burgholzer <[email protected]>
@burgholzer
🔥 remove the TN flow from the path simulator
a2719e0 
this has been a burden to maintain and some of the dependencies involved are not mature enough. Given the limited scope of the feature, it is for the best to simply remove it.

Signed-off-by: burgholzer <[email protected]>
@burgholzer
🏷️ update typestubs
a9d9c06 
Signed-off-by: burgholzer <[email protected]>
@burgholzer
🔒 update lockfile
4d779e5 
Signed-off-by: burgholzer <[email protected]>
@burgholzer
♻️ use more of MQT Core's functionality
67ee10a 
Signed-off-by: burgholzer <[email protected]>
@burgholzer
📄 update license year
646c319 
Signed-off-by: burgholzer <[email protected]>
@burgholzer burgholzer added c++ Anything related to C++ code extensive-cpp-ci Adding this label indicates that extensive C++ CI runs should be started for this PR. extensive-python-ci Adding this label indicates that extensive Python CI runs should be started for this PR. pre-commit Pull requests that update pre-commit checks github-actions Pull requests that update GitHub Actions code refactor Anything related to code refactoring labels Mar 4, 2025
This was referenced Mar 4, 2025
Closed
Closed
Closed
Closed
@burgholzer burgholzer merged commit 185c964 into main Mar 5, 2025
200 of 204 checks passed
@burgholzer burgholzer deleted the mqt-core-switch branch March 5, 2025 08:58
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQT Mar 5, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQT Simulation Mar 5, 2025
ystade pushed a commit to munich-quantum-toolkit/core that referenced this pull request Mar 5, 2025
@burgholzer @ystade
🔧 Handle empty quantum and classical registers in qiskit to MQT trans…
21030b8 
…lation (#849)

## Description

This pull request adds support for handling empty quantum and classical
registers during the translation process from Qiskit to MQT. This update
ensures proper translation and eliminates any potential errors caused by
empty registers.

This has come up while working on
munich-quantum-toolkit/ddsim#336

## Checklist:

- [x] The pull request only contains commits that are related to it.
- [x] I have added appropriate tests and documentation.
- [x] I have made sure that all CI jobs on GitHub pass.
- [x] The pull request introduces no new warnings and follows the
project's style guidelines.

Signed-off-by: burgholzer <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@burgholzer burgholzer

Labels

c++ Anything related to C++ code dependencies Pull requests that update a dependency file extensive-cpp-ci Adding this label indicates that extensive C++ CI runs should be started for this PR. extensive-python-ci Adding this label indicates that extensive Python CI runs should be started for this PR. github-actions Pull requests that update GitHub Actions code major Part of a major release packaging Anything related to Python packaging pre-commit Pull requests that update pre-commit checks python Pull requests that update Python code refactor Anything related to code refactoring usability Anything related to usability

Projects

None yet

Milestone

DDSIM 2.0

Development

Successfully merging this pull request may close these issues.

1 participant

@burgholzer